Skip to content

+double WWW-Authenticate response header. Resolve Issue #949 #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chidozieononiwu wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

+double WWW-Authenticate response header. Resolve Issue #949 #1774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ServiceStartCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,10 +483,18 @@ private IHost CreateHttpHost(ServiceStartOptions serverOptions)
HttpRequest request = context.Request;
string resourceMetadataUrl = $"{request.Scheme}://{request.Host}/.well-known/oauth-protected-resource";

context.Response.StatusCode = 401;

var header = $"Bearer realm=\"{request.Host}\", resource_metadata=\"{resourceMetadataUrl}\"";
Copy link
Member

@joshfree joshfree Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing CHANGELOG entry

if (!string.IsNullOrEmpty(context.Error))
Copy link
Member

@joshfree joshfree Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing regression test

header += $", error=\"{context.Error}\"";
if (!string.IsNullOrEmpty(context.ErrorDescription))
header += $", error_description=\"{context.ErrorDescription}\"";

// Modify the WWW-Authenticate header to include resource_metadata
context.Response.Headers.WWWAuthenticate =
$"Bearer realm=\"{request.Host}\", resource_metadata=\"{resourceMetadataUrl}\"";
context.Response.Headers.WWWAuthenticate = header;
}
context.HandleResponse();
return Task.CompletedTask;
}
};
Expand Down
Loading