Fix crash when switching bundles in playground #15478
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
reviewed
Dec 16, 2025
| winrt::Microsoft::ReactNative::ReactCoreInjection::SetTopLevelWindowId( | ||
| host.InstanceSettings().Properties(), reinterpret_cast<uint64_t>(hwnd)); | ||
|
|
||
| // Nudge the ReactNativeHost to create the instance and wrapping context |
Member
There was a problem hiding this comment.
I am just curious why this change is considered to be correct?
How the view options are updated if they are changed after the instance reload?
The PR description says nothing about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switching bundles in playground crashes in main with assertion.
Type of Change
Why
Fix crash, makes RNW playground stable.
Resolves #15477
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
switching_bundle_fix.mp4
Testing
tested in playground
Changelog
Should this change be included in the release notes: indicate no
Microsoft Reviewers: Open in CodeFlow