Skip to content

Fix crash when switching bundles in playground #15478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 1 commit into from
Dec 16, 2025
+4 −4
Merged

Fix crash when switching bundles in playground #15478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/playground/windows/playground-composition/Playground-Composition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ struct WindowData {
}

void UpdateViewOptions() {
if (!m_appName)
if (!m_appName || !m_compRootView)
return;

winrt::Microsoft::ReactNative::ReactViewOptions viewOptions;
Expand Down Expand Up @@ -263,12 +263,12 @@ struct WindowData {
winrt::Microsoft::ReactNative::ReactCoreInjection::SetTopLevelWindowId(
host.InstanceSettings().Properties(), reinterpret_cast<uint64_t>(hwnd));

// Nudge the ReactNativeHost to create the instance and wrapping context
Copy link
Member

@vmoroz vmoroz Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just curious why this change is considered to be correct?
How the view options are updated if they are changed after the instance reload?
The PR description says nothing about it.

host.ReloadInstance();

for (auto &window : g_windows) {
window->UpdateViewOptions();
}

// Nudge the ReactNativeHost to create the instance and wrapping context
host.ReloadInstance();
}

break;
Expand Down
Loading