test: fix progress notification assertions for related_request_id #2038
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress notifications were not being delivered to clients because related_request_id was not passed to send_progress_notification(), causing the SSE transport to drop the notification.
Update existing test assertions to include related_request_id, and add a dedicated test verifying that report_progress() correctly passes the request_id as related_request_id to send_progress_notification().
akshan-main
force-pushed
the
bugfix/progress-notification-missing-metadata
branch
from
1ff495b to
e4f97e4
Compare
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failing CI after #2002 added
related_request_idto progress notifications.The
report_progress()method now passesrelated_request_id=self.request_idtosend_progress_notification(), but the test intest_176_progress_token.pywas not updated to expect this new argument. This caused all 20 test matrix jobs to fail.Updated the three
assert_any_callassertions to includerelated_request_id="test-request". Added unit test