Bug 1891921 - Use mozilla-version to determine the category o…

[JohanLorenzo]

…f a release

Depends on mozilla-releng/mozilla-version#109 mozilla-releng/mozilla-version#110 and mozilla-releng/mozilla-version#111

I'm confident the current implementation is good. See what staging produced in product-details: mozilla-releng/product-details@fa9d823. See also mozilla-releng/mozilla-version#111 (comment) about expected changes in prod.

[JohanLorenzo]

See what the next commit in product details will look like: https://gist.github.com/JohanLorenzo/744122b093f6d5edfbe46488f91aedc0.

There are several type of changes:

• Missing Fenix beta versions are added. That's because the scheme we used in beta didn't follow this regex
• ESRs are correctly categorized as such (instead of being major/stability) ones. I'm not sure why we ever categorized them as major/stability while we have the ESR category too. A direct consequence of that is the disappearance of ESRs (versioned as X.Y.Z) from the major/stability json files.
• Edge cases like 14.0.1 are correctly categorized as major

[bhearsum]

I'm OK with this. Please have someone in RelMan review the expected changes to product details before landing though.

[rvandermeulen]

To be honest, I'm not sure how to even evaluate what the downstream implications of these changes are. I would definitely like @pascalchevrel to take a look when he's back next week as I suspect he may have some better knowledge about who the downstream consumers are of these json files.

As a I mentioned to jlorenzo already, I'd definitely like to confirm that this won't cause the ESR point releases to disappear from https://www.mozilla.org/firefox/releases/ to start.

[pascalchevrel]

in the patch, in firefox_history_stability_releases.json:

-    "125.0.2": "2024-04-22"
+    "125.0.2": "2024-04-16"

the initial date of "2024-04-22" was correct

Apart from that, I don't see changes that would obviously break stuff that I know of. I tested the patched version of the files with whattrainisnitnow.com which makes heavy use of product-details data and it works. LGTM

[JohanLorenzo]

Status update: I plan to update my patch to avoid making too many changes to product-details. I chatted with the Bedrock team and it's better if we keep the data the way it is. Otherwise, we will break https://www.mozilla.org/en-US/firefox/releases/, for instance. I'll get back to this PR when I'm back from vacation.

[gbrownmozilla]

Requesting changes based on the April 30 comment.