830 fix reaction wheel and thruster commanding to be spacecraft specific

[msuder]

Summary of PR goals.

How to test?

• Change file cfg/sims/nos3-simulator.xml <spacecraft> tag from 0 to 1 for the GENERICRWSIMDATA42SOCKETPROVIDER
• make -j to build and get the nos3-simulator.xml file into place
• Launch NOS3 and quickly attach gdb to 42.
  • Verify that when the SC transitions to mode 2 that the reaction wheel simulator window shows commands to spacecraft 1 reaction wheels.
  • Verify that 42 gets commands for spacecraft 1 reaction wheels at TxRxIPC.c:682.
  • Note that this will cause 42 to seg fault since there is not actually a spacecraft 1 and so we try to index a spacecraft array with an index that does not exist.
• Revert the change to nos3-simulator.xml
• Change file nos3-simulator.xml <spacecraft> tag from 0 to 1 for the GENERIC_THRUSTER_42_PROVIDER
• make -j to build and get the nos3-simulator.xml file into place
• Launch NOS3 and attach gdb to 42. Verify that you can enable the thrusters and send a thruster command from COSMOS and that it is for spacecraft 1.
  • Do this by viewing the generic thruster sim output window and by seeing in gdb the command sent for spacecraft 1 in TxRxIPC.c:698.
  • Note that 42 will segfault if you proceed since there is no SC[1].

Submodule PRs and actions prior to closing this:

• https://github.com/nasa/nos3/issues/830 - Remove _sc from GenericRWSh… nasa-itc/generic_reaction_wheel#21
• https://github.com/nasa/nos3/issues/830 - Delete dead code. Add cmd_… nasa-itc/generic_thruster#15

Closes #830 .

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.74%. Comparing base (842aa0e) to head (ad4e0db).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files         761      761           
  Lines       90262    90262           
  Branches     7133     7135    +2     
=======================================
  Hits        65664    65664           
  Misses      24598    24598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.