Skip to content

fix: race condition in /stop #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 1 commit into from
Jan 23, 2026
Merged

fix: race condition in /stop #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions launchpad/pkg/flagd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,20 @@ func stopFlagDWithoutLock() error {
if err := flagdCmd.Process.Kill(); err != nil {
return fmt.Errorf("failed to stop flagd: %v", err)
}

// Wait for the process to fully terminate with a timeout
done := make(chan error, 1)
go func() {
done <- flagdCmd.Wait()
}()

select {
case <-done:
// Process fully terminated
case <-time.After(5 * time.Second):
fmt.Println("Warning: timeout waiting for flagd process to terminate")
}

flagdCmd = nil
fmt.Println("flagd stopped")
}
Expand Down