-
Notifications
You must be signed in to change notification settings - Fork 291
registry-replacer: add ignore-repos option #4890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughAdds a new --ignore-repos flag, threads an ignoreRepos set into the registry-replacer invocation, implements early skipping of listed repos in the replacer, refactors some set construction, and updates tests and an autoconfigbrancher flag usage to cover the new behavior and metadata propagation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @cmd/autoconfigbrancher/main.go:
- Line 172: The command invocation currently uses the incorrect flag string
"--ignore-repo" which is unrecognized; change that literal to the expected
"--ignore-repos" (plural) wherever it appears in the command construction (the
argument list containing "--ignore-repo", "openshift/origin") so the
registry-replacer flag is recognized.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
cmd/autoconfigbrancher/main.go
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
cmd/autoconfigbrancher/main.go
|
/retest-required |
| configResolver func(config api.ReleaseBuildConfiguration) (api.ReleaseBuildConfiguration, error), | ||
| ) func(*api.ReleaseBuildConfiguration, *config.Info) error { | ||
| return func(config *api.ReleaseBuildConfiguration, info *config.Info) error { | ||
| // Skip repos that should use dockerfile-inputs feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI's obvious comments ;)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling required tests: Scheduling tests matching the |
|
/hold |
635aabc to
3f21d79
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest-required |
|
@Prucek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add --ignore-repos flag to registry-replacer
Changes:
The dockerfile-inputs feature will handle base image detection at build time,
while registry-replacer will skip these repos in its periodic runs.
Related: Phase 2 of dockerfile-inputs rollout (registry-replacer deprecation)
Needs: #4851