[FIX] Refresh texture state when toggling mipmaps#8455
Merged
willeastcott merged 4 commits intomainfrom Feb 12, 2026
Merged
Conversation
Update Texture#mipmaps to recalculate mip levels and mark min filter parameters dirty when toggled, so runtime mipmap changes apply immediately without requiring unrelated texture edits. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates PlayCanvas Engine texture runtime behavior so toggling Texture#mipmaps recalculates mip level count and forces sampler minification state to refresh immediately, addressing Editor viewport update issues when mipmaps are toggled at runtime.
Changes:
- Recalculate
Texture._numLevelswhenmipmapsis toggled at runtime (_updateNumLevel()). - Mark minification filter state dirty when mipmaps changes to refresh sampler state immediately.
- Preserve existing mipmap upload scheduling when enabling mipmaps, with existing WebGPU / integer-format guards.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mvaligursky
approved these changes
Feb 12, 2026
Base mip upload scheduling on effective mipmap state after _updateNumLevel, and recreate array texture storage when mip level count changes to keep immutable GPU allocation in sync. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes playcanvas/editor#1187
Summary
Texture#mipmapsto recalculate mip level count when toggled at runtimeTest plan
Mipmapsupdates viewport visuals immediatelysrc/platform/graphics/texture.js