Skip to content

[FIX] Refresh texture state when toggling mipmaps #8455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willeastcott merged 4 commits into from
Feb 12, 2026
Merged

[FIX] Refresh texture state when toggling mipmaps #8455

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c0127f
[FIX] Refresh texture state when mipmaps toggles
willeastcott Feb 12, 2026
170b290
Update src/platform/graphics/texture.js
willeastcott Feb 12, 2026
91efa9e
[FIX] Handle mipmaps toggle edge cases
willeastcott Feb 12, 2026
c5cf72a
Add s to _updateNumLevel
willeastcott Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/platform/graphics/texture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ class Texture {
if (options.numLevels !== undefined) {
this._numLevels = options.numLevels;
}
this._updateNumLevel();
this._updateNumLevels();

this._minFilter = options.minFilter ?? FILTER_LINEAR_MIPMAP_LINEAR;
this._magFilter = options.magFilter ?? FILTER_LINEAR;
Expand Down Expand Up @@ -376,7 +376,7 @@ class Texture {
this._width = Math.floor(width);
this._height = Math.floor(height);
this._depth = Math.floor(depth);
this._updateNumLevel();
this._updateNumLevels();

// re-create the implementation
this.impl = device.createTextureImpl(this);
Expand Down Expand Up @@ -421,7 +421,7 @@ class Texture {
this.renderVersionDirty = this.device.renderVersion;
}

_updateNumLevel() {
_updateNumLevels() {

const maxLevels = this.mipmaps ? TextureUtils.calcMipLevelsCount(this.width, this.height) : 1;
const requestedLevels = this._numLevelsRequested;
Expand Down Expand Up @@ -673,12 +673,25 @@ class Texture {
} else if (isIntegerPixelFormat(this._format)) {
Debug.warn('Texture#mipmaps: mipmap property cannot be changed on an integer texture, will remain false', this);
} else {
const oldMipmaps = this._mipmaps;
const oldNumLevels = this._numLevels;

this._mipmaps = v;
}
this._updateNumLevels();

if (v) {
this._needsMipmapsUpload = true;
this.device?.texturesToUpload?.add(this);
// Changing mip count on array textures requires re-creating immutable storage.
if (this.array && this._numLevels !== oldNumLevels) {
this.recreateImpl();
} else if (this._mipmaps !== oldMipmaps) {
this.propertyChanged(TEXPROPERTY_MIN_FILTER);

if (this._mipmaps) {
this._needsMipmapsUpload = true;
this.device?.texturesToUpload?.add(this);
} else {
this._needsMipmapsUpload = false;
}
}
}
}
}
Expand Down