Merged
Conversation
Member
Author
|
@CSSFrancis, I listed you as a maintainer alongside Duncan, Phillip, and myself in the release info. Which I thought you already were. I hope this is OK? |
CSSFrancis
approved these changes
May 12, 2024
Member
CSSFrancis
left a comment
There was a problem hiding this comment.
@CSSFrancis, I listed you as a maintainer alongside Duncan, Phillip, and myself in the release info. Which I thought you already were. I hope this is OK?
That's probably fine. I haven't really done much with diffsims until recently so it makes sense, I was planning on doing some more in the next couple of months.
As far as the PR goes I looked through all of the changes and it looks good to me
Member
Author
|
Great and great! Thanks for looking it over. We should be good to merge and release once your doc examples PR is in. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…tice Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
c3cb8ac to
5bbd6f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Release prep:
Other changes:
StructureLibrary.from_crystal_systems(). The method previously threw a NotImplementedError, but will now throw an AttributeError. Mentioned in the changelog under Removed.Rotation.from_neo_euler()withRotation.from_axes_angles().I've cleaned up the test suite a bit:
xfail(error)withwith pytest.raises(error):. To me, it seems like best practice is to use the latter when we intentionally raise errors in the code, while the former is mostly used as a temporary measure for bugs that will be fixed.plt.close()(silencing a warning of > 20 open plots from Matplotlib)Progress of the PR
For reviewers
__init__.py.unreleased section in
CHANGELOG.rst.creditsindiffsims/release_info.pyandin
.zenodo.json.