Skip to content

feat: add a tooltip for copying values in leaderboard #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdityaHegde wants to merge 3 commits into
base: main
Choose a base branch
from
+152 −141
Draft

feat: add a tooltip for copying values in leaderboard #8596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d60e630
feat: add a tooltip for copying values in leaderboard
AdityaHegde Jan 7, 2026
fde534e
Merge branch 'main' into feat/value-copy-tooltip-in-leaderboards
AdityaHegde Jan 8, 2026
2ca3098
Replace wil LeaderboardCell
AdityaHegde Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 124 additions & 0 deletions web-common/src/features/dashboards/leaderboard/LeaderboardCell.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
<script lang="ts">
import { onDestroy } from "svelte";
import * as Tooltip from "@rilldata/web-common/components/tooltip-v2";
import Shortcut from "@rilldata/web-common/components/tooltip/Shortcut.svelte";
import StackingWord from "@rilldata/web-common/components/tooltip/StackingWord.svelte";
import {
copyToClipboard,
isClipboardApiSupported,
} from "@rilldata/web-common/lib/actions/copy-to-clipboard.ts";
import { builderActions, getAttrs } from "bits-ui";
import { TOOLTIP_STRING_LIMIT } from "@rilldata/web-common/layout/config.ts";
import { modified } from "@rilldata/web-common/lib/actions/modified-click.ts";
import { cellInspectorStore } from "@rilldata/web-common/features/dashboards/stores/cell-inspector-store.ts";

export let value: string;
export let type: "dimension" | "measure" | "comparison";
export let className: string = "";
export let background: string = "";

const HideLeaderboardTooltipAfter = 3000;

const clipboardSupported =
typeof navigator !== "undefined" ? isClipboardApiSupported() : false;
const disabled = !clipboardSupported;

let tooltipActive = false;
$: if (tooltipActive) {
showTemporarily();
}

let hideTimer: ReturnType<typeof setTimeout> | undefined;

function clearHideTimer() {
if (hideTimer) {
clearTimeout(hideTimer);
hideTimer = undefined;
}
}

function showTemporarily() {
if (disabled) return;
clearHideTimer();
hideTimer = setTimeout(() => {
tooltipActive = false;
}, HideLeaderboardTooltipAfter);
}

function shiftClickHandler(label: string) {
let truncatedLabel = label?.toString();
if (truncatedLabel?.length > TOOLTIP_STRING_LIMIT) {
truncatedLabel = `${truncatedLabel.slice(0, TOOLTIP_STRING_LIMIT)}...`;
}
copyToClipboard(
label,
`copied dimension value "${truncatedLabel}" to clipboard`,
);
}

onDestroy(clearHideTimer);
</script>

<Tooltip.Root bind:open={tooltipActive} openDelay={1000}>
<Tooltip.Trigger asChild let:builder {disabled}>
<td
role="button"
tabindex="0"
{...getAttrs([builder])}
use:builderActions={{ builders: [builder] }}
on:click={modified({
shift: () => shiftClickHandler(value),
})}
on:pointerover={() => {
if (value) {
// Always update the value in the store, but don't change visibility
cellInspectorStore.updateValue(value.toString());
}
}}
on:focus={() => {
if (value) {
// Always update the value in the store, but don't change visibility
cellInspectorStore.updateValue(value.toString());
}
}}
style:background
class="{type}-cell {className}"
>
<slot />
</td>
</Tooltip.Trigger>

{#if clipboardSupported && !disabled}
<Tooltip.Content class="max-w-[280px] bg-popover-foreground">
<div>
<StackingWord key="shift">Copy</StackingWord>
{value} to clipboard
</div>
<Shortcut>
<span style="font-family: var(--system);">⇧</span> + Click
</Shortcut>
</Tooltip.Content>
{/if}
</Tooltip.Root>

<style lang="postcss">
td {
@apply text-right p-0;
@apply px-2 relative;
height: 22px;
}

/*td.comparison-cell {*/
/* @apply bg-surface px-1 truncate;*/
/*}*/

/*td.dimension-cell {*/
/* @apply sticky left-0 z-30 bg-surface;*/
/*}*/

:global(tr:hover .dimension-cell),
:global(tr:hover .measure-cell),
:global(tr:hover .comparison-cell) {
@apply bg-gray-100;
}
</style>
169 changes: 28 additions & 141 deletions web-common/src/features/dashboards/leaderboard/LeaderboardRow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@
import FormattedDataType from "@rilldata/web-common/components/data-types/FormattedDataType.svelte";
import PercentageChange from "@rilldata/web-common/components/data-types/PercentageChange.svelte";
import ExternalLink from "@rilldata/web-common/components/icons/ExternalLink.svelte";
import { TOOLTIP_STRING_LIMIT } from "@rilldata/web-common/layout/config";
import { copyToClipboard } from "@rilldata/web-common/lib/actions/copy-to-clipboard";
import { modified } from "@rilldata/web-common/lib/actions/modified-click";
import { clamp } from "@rilldata/web-common/lib/clamp";
import { formatMeasurePercentageDifference } from "@rilldata/web-common/lib/number-formatting/percentage-formatter";
import { slide } from "svelte/transition";
import { type LeaderboardItemData, makeHref } from "./leaderboard-utils";
import { cellInspectorStore } from "../stores/cell-inspector-store";
import LeaderboardItemFilterIcon from "./LeaderboardItemFilterIcon.svelte";
import LongBarZigZag from "./LongBarZigZag.svelte";
import {
Expand All @@ -19,6 +15,7 @@
deltaColumn,
MEASURES_PADDING,
} from "./leaderboard-widths";
import LeaderboardCell from "@rilldata/web-common/features/dashboards/leaderboard/LeaderboardCell.svelte";

export let itemData: LeaderboardItemData;
export let dimensionName: string;
Expand Down Expand Up @@ -160,16 +157,9 @@
}),
);

function shiftClickHandler(label: string) {
let truncatedLabel = label?.toString();
if (truncatedLabel?.length > TOOLTIP_STRING_LIMIT) {
truncatedLabel = `${truncatedLabel.slice(0, TOOLTIP_STRING_LIMIT)}...`;
}
copyToClipboard(
label,
`copied dimension value "${truncatedLabel}" to clipboard`,
);
}
$: dimensionCellClass = `relative size-full flex flex-none justify-between items-center leaderboard-label ${
atLeastOneActive ? "cursor-pointer" : ""
} ${excluded ? "ui-copy-disabled" : ""} ${!excluded && selected ? "ui-copy-strong" : ""}`;

function onDimensionCellClick(e: MouseEvent) {
// Check if user has selected text
Expand Down Expand Up @@ -211,30 +201,11 @@
selectionIndex={itemData?.selectedIndex}
/>
</td>
<td
role="button"
tabindex="0"
data-dimension-cell
class:ui-copy={!atLeastOneActive}
class:ui-copy-disabled={excluded}
class:ui-copy-strong={!excluded && selected}
on:click={modified({
shift: () => shiftClickHandler(dimensionValue),
})}
on:pointerover={() => {
if (dimensionValue) {
// Always update the value in the store, but don't change visibility
cellInspectorStore.updateValue(dimensionValue.toString());
}
}}
on:focus={() => {
if (dimensionValue) {
// Always update the value in the store, but don't change visibility
cellInspectorStore.updateValue(dimensionValue.toString());
}
}}
class="relative size-full flex flex-none justify-between items-center leaderboard-label"
style:background={dimensionGradients}
<LeaderboardCell
value={dimensionValue}
type="dimension"
className={dimensionCellClass}
background={dimensionGradients}
>
<span class="truncate select-text">
<FormattedDataType value={dimensionValue} truncate />
Expand Down Expand Up @@ -263,31 +234,15 @@
</a>
</span>
{/if}
</td>
</LeaderboardCell>

{#each Object.keys(values) as measureName}
<td
role="button"
tabindex="0"
data-measure-cell
on:click={modified({
shift: () => shiftClickHandler(values[measureName]?.toString() || ""),
})}
style:background={leaderboardMeasureNames.length === 1
<LeaderboardCell
value={values[measureName]?.toString() || ""}
type="measure"
background={leaderboardMeasureNames.length === 1
? measureGradients
: measureGradientMap?.[measureName]}
on:pointerover={() => {
const value = values[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
on:focus={() => {
const value = values[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
>
<div class="w-fit ml-auto bg-transparent" bind:contentRect={valueRect}>
<FormattedDataType
Expand All @@ -301,29 +256,12 @@
{#if showZigZags[measureName] && !isTimeComparisonActive && !isValidPercentOfTotal(measureName)}
<LongBarZigZag />
{/if}
</td>
</LeaderboardCell>

{#if isValidPercentOfTotal(measureName) && shouldShowContextColumns(measureName)}
<td
role="button"
tabindex="0"
data-comparison-cell
on:click={modified({
shift: () =>
shiftClickHandler(pctOfTotals[measureName]?.toString() || ""),
})}
on:pointerover={() => {
const value = pctOfTotals[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
on:focus={() => {
const value = pctOfTotals[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
<LeaderboardCell
value={pctOfTotals[measureName]?.toString() || ""}
type="comparison"
>
<PercentageChange
value={pctOfTotals[measureName]}
Expand All @@ -332,30 +270,13 @@
{#if showZigZags[measureName]}
<LongBarZigZag />
{/if}
</td>
</LeaderboardCell>
{/if}

{#if isTimeComparisonActive && shouldShowContextColumns(measureName)}
<td
role="button"
tabindex="0"
data-comparison-cell
on:click={modified({
shift: () =>
shiftClickHandler(deltaAbsMap[measureName]?.toString() || ""),
})}
on:pointerover={() => {
const value = deltaAbsMap[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
on:focus={() => {
const value = deltaAbsMap[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
<LeaderboardCell
value={deltaAbsMap[measureName]?.toString() || ""}
type="comparison"
>
<FormattedDataType
color="text-gray-500"
Expand All @@ -369,28 +290,13 @@
: ""}
truncate={true}
/>
</td>
</LeaderboardCell>
{/if}

{#if isTimeComparisonActive && shouldShowContextColumns(measureName)}
<td
data-comparison-cell
on:click={modified({
shift: () =>
shiftClickHandler(deltaRels[measureName]?.toString() || ""),
})}
on:pointerover={() => {
const value = deltaRels[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
on:focus={() => {
const value = deltaRels[measureName]?.toString() || "";
if (value) {
cellInspectorStore.updateValue(value);
}
}}
<LeaderboardCell
value={deltaRels[measureName]?.toString() || ""}
type="comparison"
>
<PercentageChange
value={deltaRels[measureName]
Expand All @@ -401,16 +307,14 @@
{#if showZigZags[measureName]}
<LongBarZigZag />
{/if}
</td>
</LeaderboardCell>
{/if}
{/each}
</tr>

<style lang="postcss">
td {
@apply text-right p-0;
@apply px-2 relative;
height: 22px;
@apply bg-surface h-[22px] p-0 px-1 truncate text-right;
}

tr {
Expand All @@ -422,19 +326,6 @@
@apply bg-gray-100;
}

td[data-comparison-cell] {
@apply bg-surface px-1 truncate;
}

td[data-dimension-cell] {
@apply sticky left-0 z-30 bg-surface;
}

tr:hover td[data-dimension-cell],
tr:hover td[data-comparison-cell] {
@apply bg-gray-100;
}

.external-link-wrapper a {
opacity: 0;
position: absolute;
Expand All @@ -452,8 +343,4 @@
backdrop-filter: blur(2px);
-webkit-backdrop-filter: blur(2px);
}

td {
height: 22px !important;
}
</style>
Loading