Open
Conversation
Add a check for fastANI to prevent running of loop and echoing of messages that indicate the job is being successfully run
Add a dependency check for fastANI to prevent loop being run anyway and messages indicating the job is running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ryan,
After running fastANI and getting some blank outputs I was confused as the fastANI scripts were suggesting that the job was actually being run. Later I realised I hadn't installed fastANI and that errors caused by fastANI not being found were not being correctly broadcast to the standard out.
I added in a dependency check to both of the looping fastANI scripts. This isn't necessary for the single thread script as the error message is properly shown when fastANI is not installed.
Thanks for putting Bacsort together, it is very helpful.
Cheers,
Max