Sorting special characters feature parity #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryqh
force-pushed
the
ph/sorting-parity
branch
from
7f263ba to
69f1560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubyatscale/code_ownership#109
The problem
The special characters
*and(default sort order is(and then*.The last matching pattern in the
CODEOWNERSfile is used to determine file ownership.Example from our super-large-mono-repo:
/directory/owner/(my_folder)/**/**has an assigned order offoo/directory/owner/**has an assigned order ofbarDefault sorting would place the
/directory/owner/**line last giving it precedence, but/directory/owner/(my_folder)/**/**is more specific and should have precedence.Fix
Customize CODEOWNERS line sorting to have a special case for lines containing
**characters.