Skip to content

fix: improve container cleanup in e2e aftereach step#288

Open
ayush-panta wants to merge 1 commit intomainfrom
fix-e2e-aftereach
Open

fix: improve container cleanup in e2e aftereach step#288
ayush-panta wants to merge 1 commit intomainfrom
fix-e2e-aftereach

Conversation

@ayush-panta
Copy link
Contributor

Description of changes: The Build, test and upload .deb to S3 workflow in Finch has been consistently. The issue occurs when RemoveContainers() attempts to remove containers after tests complete. I believe the cleanup code was too strict - it expected all container removal operations to succeed. When rm --force failed or timed out (due to containers not being fully stopped, resource contention, or timing issues), the entire test would fail even though the actual test logic passed.

Testing done: I ran the focused test command below in common-tests and got all passing:

go test -timeout 30m ./run/... -test.v -ginkgo.v -ginkgo.focus="user" -args --subject="finch" 2>&1 | tee user-test.log

However, I need to do more testing to confirm this fix.

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: ayush-panta <ayushkp@amazon.com>
@ayush-panta ayush-panta requested a review from a team as a code owner February 20, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant