Skip to content

fix: improve container cleanup in e2e aftereach step #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayush-panta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve container cleanup in e2e aftereach step #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion command/remove.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@ func RemoveContainers(o *option.Option) {
return
}

// Stop all containers first to ensure they can be removed
stopArgs := append([]string{"stop", "--time", "1"}, ids...)
New(o, stopArgs...).WithoutCheckingExitCode().Run()

// Remove containers, ignoring failures to prevent test cleanup from failing
args := append([]string{"rm", "--force"}, ids...)
Run(o, args...)
New(o, args...).WithoutCheckingExitCode().Run()
}

// RemoveVolumes removes all unused local volumes in the testing environment specified by o.
Expand Down