Open
Conversation
All requests should have this field; completion in jeejah breaks without it.
Previously this was mistakenly using cdadr to extract the completion candidates, which would only work by accident if the response message did not include any different fields than expected.
This was passing in 'local in the wrong argument, so it did not have the desired effect.
Owner
|
Can you try pls with [1] version? I've merged couple of patches before, mostly related to multiple connection support and weird things happens from time to time. I'm loosing content with the last master (no evaluations) and it's a bit hard to debug, so I was planning to revert stuff to [1] and apply other patches done in the mean time. Thoughts? [1] 508f5ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging a new version of Jeejah, I encountered several bugs in Monroe's completion logic.
completionsrequest was missing thesessionfield, which all messages should have.monroe-completion-at-pointfunction was usingcdadrto extract the "candidate" field instead of actually looking for the completion by name. This probably worked on whatever server it was originally tested with, but it would fail as soon as the response had a different number of fields from that.add-hookcall formonroe-completion-at-pointwas not correctly making the hook changes buffer-local.However, even after fixing these bugs, I've been unable to get completion working. I've confirmed that responses come back over nrepl like such:
but Monroe still does not correctly show or insert candidates returned by the server. Not sure what's going on there.