Skip to content

Fix several completion bugs #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
technomancy wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix several completion bugs #48

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58030a6
Send session field in completions request.
technomancy Nov 16, 2025
1da5543
Look for completion candidates in the candidate field.
technomancy Nov 16, 2025
35d5e1e
Add monroe-completion-at-point hook locally.
technomancy Nov 16, 2025
c508ca5
Fall back to user ns if completion ns isn't found.
technomancy Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions monroe.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,9 @@ inside a container.")
(goto-char (point-min))
(forward-line (1- line)))))))))

(defun monroe-completion-candidate (completions)
(monroe-dbind-response completions (candidate) candidate))

(defun monroe-completion-at-point ()
"Function to be used for the hook 'completion-at-point-functions'."
(interactive)
Expand All @@ -524,11 +527,13 @@ inside a container.")
(ns (monroe-get-clojure-ns))
(sym (thing-at-point 'symbol))
(response (monroe-send-sync-request (list "op" "completions"
"ns" ns
"ns" (or ns "user")
"session" (monroe-current-session)
"prefix" sym))))
(monroe-dbind-response response (completions)
(when completions
(list start end (mapcar 'cdadr completions) nil)))))
(let ((candidates (mapcar 'monroe-completion-candidate completions)))
(list start end candidates nil))))))

(defun monroe-get-stacktrace ()
"When error happens, print the stack trace"
Expand Down Expand Up @@ -667,7 +672,7 @@ The following keys are available in `monroe-mode':
(setq comint-input-sender 'monroe-input-sender)
(setq mode-line-process '(":%s"))
;(set (make-local-variable 'font-lock-defaults) '(clojure-font-lock-keywords t))
(add-hook 'completion-at-point-functions #'monroe-completion-at-point 'local)
(add-hook 'completion-at-point-functions #'monroe-completion-at-point nil 'local)
;; a hack to keep comint happy
(unless (comint-check-proc (current-buffer))
(let ((fake-proc (start-process "monroe" (current-buffer) nil)))
Expand Down