Use 'xrandr' to determine DPI on Linux, especially with wayland#17
Draft
edwintorok wants to merge 2 commits intosanette:masterfrom
Draft
Use 'xrandr' to determine DPI on Linux, especially with wayland#17edwintorok wants to merge 2 commits intosanette:masterfrom
edwintorok wants to merge 2 commits intosanette:masterfrom
Conversation
…for auto-detection" It doesn't work consistently with different versions of SDL2+wayland. It is either twice as big or twice as small than it should be. This reverts commit 7dcbb6d.
SDL2+wayland in various versions reports different DPI depending on scaling. On some versions it reports the monitor's true DPI regardless of desktop scale factor. In other versions it scales the monitor's DPI down based on desktop scale factor. However there isn't a way to detect which one it is, so the only reliable way to get DPI on wayland ... is to rely on XWayland and xrandr which reports all this correctly. (or use wayland-info but that isn't always installed). 'xdpyinfo' would report a bogus 96 DPI always, so that cannot be used. Signed-off-by: Edwin Török <edwin@etorok.net>
Contributor
Author
|
I still need to test this in various configurations, but it should implement the basic idea discussed in the other PR. |
Owner
|
do this still need to be merged,? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #16, SDL2's wayland support is not great and different versions report DPI differently based on desktop scaling.
Latest SDL2 version (at least on Fedora 37) seems to have wayland reenabled by default, but still quite problematic.
Fall back to using 'xrandr' for now, which seems to report correct DPI.