Skip to content

Y25-715 - creating a balanced pool tube as soon as the first run finishes#2707

Open
KatyTaylor wants to merge 1 commit intodevelopfrom
Y25-715-take-2
Open

Y25-715 - creating a balanced pool tube as soon as the first run finishes#2707
KatyTaylor wants to merge 1 commit intodevelopfrom
Y25-715-take-2

Conversation

@KatyTaylor
Copy link
Collaborator

@KatyTaylor KatyTaylor commented Feb 16, 2026

Closes #2654

See related Integration Suite change - https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/305 - the test was not broken, but this removes now-unnecessary parts.

Changes proposed in this pull request

  • remove plate_downstream_completed_presenter and related code due to change in requirement

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (1b9b14c) to head (71b1558).
⚠️ Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2707      +/-   ##
===========================================
+ Coverage    84.59%   84.61%   +0.02%     
===========================================
  Files          501      500       -1     
  Lines        20538    20578      +40     
  Branches       377      377              
===========================================
+ Hits         17374    17412      +38     
- Misses        3161     3163       +2     
  Partials         3        3              
Flag Coverage Δ
javascript 79.71% <ø> (ø)
pull_request 84.57% <ø> (-0.02%) ⬇️
push 84.54% <ø> (-0.06%) ⬇️
ruby 92.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KatyTaylor KatyTaylor marked this pull request as ready for review February 16, 2026 15:24
@KatyTaylor
Copy link
Collaborator Author

Screenshots of button showing / not showing in different states:

No children made yet, charge and pass not pressed yet:
Screenshot 2026-02-16 at 15 44 24

No children yet, charge and pass clicked:
Screenshot 2026-02-16 at 15 44 50

EqVol child made, sequencing requests not passed yet:
Screenshot 2026-02-16 at 15 31 35

End of the pipeline, EqVol and EqMol tubes all made:
Screenshot 2026-02-16 at 15 41 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-715 - creating a balanced pool tube as soon as the first run finishes

3 participants

Comments