Draft
Conversation
Tested, 100% the same as PPO.
Same up to 1e-5 on individual values. Because of differencing, this can end up in much larger differences (1e0) occasionally, after normalization.
Left without boot-strapping on last step, seems like it makes no difference. Boot-strapping on time-outs made a big difference though.
Pytest v8 causes import errors:
```
E _pytest.nodes.Collector.CollectError: ImportError while importing test module '/home/heim/Repos/QGym/gym/utils/__init__.py'.
E Hint: make sure your test modules/packages have valid Python names.
E Traceback:
E ../../.pyenv/versions/3.8.18/lib/python3.8/importlib/__init__.py:127: in import_module
E return _bootstrap._gcd_import(name[level:], package, level)
E gym/utils/__init__.py:31: in <module>
E from .helpers import (
E gym/utils/helpers.py:36: in <module>
E from isaacgym import gymapi
E ../isaacgym/python/isaacgym/__init__.py:5: in <module>
E from isaacgym import gymapi
E ../isaacgym/python/isaacgym/gymapi.py:21: in <module>
E from . import gymdeps
E ../isaacgym/python/isaacgym/gymdeps.py:63: in <module>
E _import_deps()
E ../isaacgym/python/isaacgym/gymdeps.py:21: in _import_deps
E raise ImportError("PyTorch was imported before isaacgym modules. Please import torch after isaacgym modules.")
E E ImportError: PyTorch was imported before isaacgym modules. Please import torch after isaacgym modules.
../../.local/share/virtualenvs/QGym-vLS1XcJm/lib/python3.8/site-packages/_pytest/python.py:563: CollectError
==================================================== short test summary info ====================================================
ERROR gym/envs/mit_humanoid/test_coupling.py::test_coupling - _pytest.nodes.Collector.CollectError: ImportError while importing test module '/home/heim/Repos/QGym/gym/envs/__init__.py'.
ERROR gym/utils/math/test_math.py::test_wrap_to_pi - _pytest.nodes.Collector.CollectError: ImportError while importing test module '/home/heim/Repos/QGym/gym/utils/__init__.py'.
ERROR gym/utils/math/test_math.py::test_torch_rand_sqrt_float - _pytest.nodes.Collector.CollectError: ImportError while importing test module '/home/heim/Repos/QGym/gym/utils/__init__.py'.
ERROR gym/utils/math/test_math.py::test_exp_avg_filter - _pytest.nodes.Collector.CollectError: ImportError while importing test module '/home/heim/Repos/QGym/gym/utils/__init__.py'.
```
…teration logging.
update logger to allow flexibly adding arbitrary categories for per-iteration logging.
jschneider03
commented
Mar 8, 2024
jschneider03
commented
Mar 8, 2024
jschneider03
commented
Mar 8, 2024
jschneider03
commented
Mar 8, 2024
jschneider03
commented
Mar 8, 2024
Owner
|
Please always put in the PR description the command line to run, with the cli arguments, caus' I forget them |
Runner burnin
- ruff the code.
jschneider03
commented
May 3, 2024
jschneider03
commented
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to highlight recent changes to LQC project and make it easy to ask some line-by-line questions