refactor(schematics): update schematics for modal initialstate#1539
refactor(schematics): update schematics for modal initialstate#1539akashsonune wants to merge 1 commit intomainfrom
Conversation
akashsonune
commented
Feb 17, 2026
- I confirm that this MR follows the contribution guidelines.
There was a problem hiding this comment.
Code Review
This pull request adds a schematic to migrate the initialState property of ModalOptions to inputValues. The implementation is a good start, and the suggestion to make the module matching more robust by anchoring the regex has been retained. Additionally, this change would benefit from having tests to ensure the migration works as expected and to prevent future regressions. Please consider adding a test case for this migration.
| ] | ||
| }, | ||
| { | ||
| module: /@(siemens|simpl)\/element-ng(\/modal)?/, |
There was a problem hiding this comment.
The regular expression for the module path is not anchored. This could lead to incorrect matches if a module path contains @(siemens|simpl)/element-ng(/modal)? as a substring. To ensure an exact match, it's better to anchor the regex with ^ and $.
| module: /@(siemens|simpl)\/element-ng(\/modal)?/, | |
| module: /^@(siemens|simpl)\/element-ng(\/modal)?$/, |