Skip to content

refactor(schematics): update schematics for modal initialstate #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akashsonune wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Draft

refactor(schematics): update schematics for modal initialstate #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions projects/element-ng/schematics/migrations/data/class-member-replacement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,12 @@ export const CLASS_MEMBER_REPLACEMENTS_MIGRATION: ClassMemberReplacementInstruct
{ property: 'isXl', replacement: '${expression}.xl()' },
{ property: 'isXxl', replacement: '${expression}.xxl()' }
]
},
{
module: /@(siemens|simpl)\/element-ng(\/modal)?/,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regular expression for the module path is not anchored. This could lead to incorrect matches if a module path contains @(siemens|simpl)/element-ng(/modal)? as a substring. To ensure an exact match, it's better to anchor the regex with ^ and $.

Suggested change
module: /@(siemens|simpl)\/element-ng(\/modal)?/,
module: /^@(siemens|simpl)\/element-ng(\/modal)?$/,

typeNames: ['ModalOptions'],
propertyReplacements: [
{ property: 'initialState', replacement: '${expression}.inputValues' }
]
}
];
Loading