Fixed crash during connection with 'plaintext_login' option#106
Merged
jgoclawski merged 1 commit intomasterfrom Mar 7, 2025
Merged
Fixed crash during connection with 'plaintext_login' option#106jgoclawski merged 1 commit intomasterfrom
jgoclawski merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally submitted in #94
I did a rebase and removed the encoding bit at the beginning of
RouterOsApiPool. The bytes/string inconsistencies are frustrating, but since I don't know what exactly happens when non ASCII characters are used in login/password, I think it's safer to allow people to passusernameandpasswordasbytesas well and handle the potential encoding themselves. This code will acceptbytesand use it as-is and acceptstringand encode it using the default encoding (utf-8).