Fixed crash during connection with 'plaintext_login' option#94
Closed
Njinx wants to merge 1 commit intosocialwifi:masterfrom
Closed
Fixed crash during connection with 'plaintext_login' option#94Njinx wants to merge 1 commit intosocialwifi:masterfrom
Njinx wants to merge 1 commit intosocialwifi:masterfrom
Conversation
Member
|
Thanks, merged in #106. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If 'plaintext_login' is enabled then the username and password will be
.encode()'d twice inlogin(). This PR removes type ambiguity of the username and password in__init__()and consolidates thelogin()type casts.I'm not very familiar with the RouterOS protocol but based on my testing the encoding of the username and password doesn't differ depending on whether 'plaintext_login' is used.