-
Notifications
You must be signed in to change notification settings - Fork 2
Add AWS STS authentication tutorial and cross-references #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -431,6 +431,16 @@ spec: | |||||||||||||||||
| Now the proxy exchanges validated company tokens for remote service tokens | ||||||||||||||||||
| before forwarding requests. | ||||||||||||||||||
|
|
||||||||||||||||||
| :::tip[AWS services] | ||||||||||||||||||
|
|
||||||||||||||||||
| For AWS services like the AWS MCP Server, use `type: awsSts` instead of | ||||||||||||||||||
| `type: tokenExchange`. This exchanges OIDC tokens for temporary AWS credentials | ||||||||||||||||||
| via `AssumeRoleWithWebIdentity` and signs requests with SigV4. See the | ||||||||||||||||||
|
Comment on lines
+436
to
+438
|
||||||||||||||||||
| For AWS services like the AWS MCP Server, use `type: awsSts` instead of | |
| `type: tokenExchange`. This exchanges OIDC tokens for temporary AWS credentials | |
| via `AssumeRoleWithWebIdentity` and signs requests with SigV4. See the | |
| In ToolHive installations where `MCPExternalAuthConfig.spec.type` supports the | |
| `awsSts` mode (check your installed CRD or reference docs), you can use | |
| `type: awsSts` instead of `type: tokenExchange` for AWS services like the AWS | |
| MCP Server. This exchanges OIDC tokens for temporary AWS credentials via | |
| `AssumeRoleWithWebIdentity` and signs requests with SigV4. See the |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -261,3 +261,6 @@ Key points in this example: | |||||||||
| servers in Kubernetes | ||||||||||
| - [CRD specification](../reference/crd-spec.md) - complete CRD reference | ||||||||||
| including MCPExternalAuthConfig | ||||||||||
| - [AWS STS integration](../tutorials/aws-sts-integration.mdx) - for AWS | ||||||||||
| services, ToolHive has built-in STS support using `MCPExternalAuthConfig` with | ||||||||||
| `type: awsSts` | ||||||||||
|
Comment on lines
+265
to
+266
|
||||||||||
| services, ToolHive has built-in STS support using `MCPExternalAuthConfig` with | |
| `type: awsSts` | |
| services, ToolHive has built-in STS support; see this tutorial and the | |
| MCPExternalAuthConfig CRD reference for the correct configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section claims built-in AWS STS support, but the current CRD spec documentation for
MCPExternalAuthConfigdoesn’t include anawsStstype/config. Please align this concept doc with the actual shipped CRD (or update the CRD reference docs in the same change) to avoid documenting unsupported configuration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this (and other similar comments from Copilot) are because a release hasn't been cut with these new fields yet? That will auto-update the CRD reference.