Resolve machinekit-hal python issues on noetic branch Adding support for socfpga boards with current machinekit-hal#19
Open
the-snowwhite wants to merge 34 commits intotormach:noetic-develfrom
Conversation
GH Actions should test branches whose name contain `/`. (PRs whose branches contain `/` are tested, though.)
This renames init to init_hal to better describe what it does. This should be safe to do because init_hal is called explicitly (not via virtual dispatch).
`RedisStoreHalPin` is now more similar to the ROS topic and service pins. It has an `update()` function for copying input and IO pin values to redis, and a `redis_store` `ConfigClient` callback for writing redis updates to output and IO pins. Likewise, the `hal_io` component now may have redis pins. The `hal_offset_mgr` component has been removed; if it is ever revived, it will need minor rework for the new pin updates.
The pin publisher fails to publish the last change occurring in a quick succession, instead latching a stale value. This change fixes that by comparing the pin value with the currently latched value rather than the locally-stored version that was going stale.
- Replace deprecated `check-byte-order-marker` - Remove unwanted `fix-encoding-pragma` - Remove unneeded QML checks - Run `pre-commit autoupdate`
CMake Warning (dev) at CMakeLists.txt:2 (project):
Policy CMP0048 is not set: project() command manages VERSION variables.
Run "cmake --help-policy CMP0048" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
The following variable(s) would be set to empty:
CMAKE_PROJECT_VERSION
CMAKE_PROJECT_VERSION_MAJOR
CMAKE_PROJECT_VERSION_MINOR
CMAKE_PROJECT_VERSION_PATCH
This warning is for project developers. Use -Wno-dev to suppress it.
Everything a ROS package needs to build a HAL instcomp: - `FindHAL.cmake` locates HAL include directory and `instcomp` script - `UseHALComp.cmake` builds and installs the comp with `hal_add_instcomp` - Export the `machinekit-dev` build requirement - `loadrt_local()` Python function loads the HAL comp from non-standard location The CMake config really belongs in Machinekit.
Completes a TODO in the code
Tests became stale over time
$ ( .github/workflows/upstream_install.sh; )
/home/runner/work/_actions/ros-industrial/industrial_ci/master/industrial_ci/src/util.sh:
.github/workflows/upstream_install.sh: /usr/bin/bash: bad
interpreter: No such file or directory
'before_setup_upstream_workspace' returned with code '126' after 0
min 0 sec
Error: Process completed with exit code 126.
Easier to pick out failure reason from logs
This error cropped up a month or so ago:
build mvdan.cc/sh/v3/cmd/shfmt: cannot load io/fs: malformed module path "io/fs": missing dot in first path element
Fix is to update the golang version. The Debian Buster `golang`
package is still at 1.13, whereas the latest release is 1.17.
Signed-off-by: the-snowwhite <producer@holotronic.dk>
Signed-off-by: the-snowwhite <producer@holotronic.dk>
Signed-off-by: the-snowwhite <producer@holotronic.dk>
…ol into noetic-devel
Signed-off-by: the-snowwhite <producer@holotronic.dk>
…ol into noetic-devel
Signed-off-by: the-snowwhite <producer@holotronic.dk>
Signed-off-by: the-snowwhite <producer@holotronic.dk>
the-snowwhite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to current machinekit-hal.
Tested with 2 socfpga boards armhf and arm64.
#18