feat(ecsBasePattern): allow enabling spot provider#53
Open
tm-lmathieu wants to merge 2 commits intomainfrom
Open
feat(ecsBasePattern): allow enabling spot provider#53tm-lmathieu wants to merge 2 commits intomainfrom
tm-lmathieu wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for enabling Spot capacity providers in ECS Fargate services. When enabled, the service will be configured to use a combination of FARGATE and FARGATE_SPOT capacity providers, with FARGATE_SPOT weighted to handle the majority of tasks.
Changes:
- Added
enableSpotCapacityProviderproperty to configure Spot capacity - Implemented capacity provider strategy with FARGATE as base and FARGATE_SPOT weighted for scaling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+123
to
+125
| /* | ||
| * Enable Spot Capacity Provider | ||
| */ |
There was a problem hiding this comment.
The comment uses single-line comment syntax /* instead of the JSDoc format. For consistency with the rest of the interface properties, use JSDoc format /** with a proper description.
| } | ||
|
|
||
| const mergedProps = { | ||
| ...defautProps, |
There was a problem hiding this comment.
Corrected spelling of 'defautProps' to 'defaultProps'.
Signed-off-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #