Skip to content

feat(ecsBasePattern): allow enabling spot provider #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tm-lmathieu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ecsBasePattern): allow enabling spot provider #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e95bd0
feat(ecsBasePattern): allow enabling spot provider
tm-lmathieu Jan 26, 2026
8440083
chore: self mutation
invalid-email-address Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions API.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 26 additions & 1 deletion src/containers/ecs/ecs-base-pattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ export interface TmApplicationLoadBalancedFargateServiceProps extends ecsPattern
* targetMemoryUtilizationPercent
*/
readonly targetMemoryUtilizationPercent?: number;

/*
* Enable Spot Capacity Provider
*/
Comment on lines +123 to +125
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment uses single-line comment syntax /* instead of the JSDoc format. For consistency with the rest of the interface properties, use JSDoc format /** with a proper description.

Copilot uses AI. Check for mistakes.
readonly enableSpotCapacityProvider?: boolean;
}


Expand Down Expand Up @@ -163,7 +168,27 @@ export class TmApplicationLoadBalancedFargateService extends ecsPatterns.Applica
},
};

const mergedProps = { ...defautProps, ...props };
let capacityProviderStrategies;
if (props.enableSpotCapacityProvider) {
capacityProviderStrategies = [
{
capacityProvider: 'FARGATE',
base: 1,
weight: 0,
},
{
capacityProvider: 'FARGATE_SPOT',
base: 0,
weight: 1,
},
];
}

const mergedProps = {
...defautProps,
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'defautProps' to 'defaultProps'.

Copilot uses AI. Check for mistakes.
...props,
...(capacityProviderStrategies && { capacityProviderStrategies }),
};

super(scope, id, mergedProps);

Expand Down