[WIP] Implementing new unit tests for IFC4X3_ RC4 by Elvira2227 · Pull Request #478 · tumcms/Open-Infra-Platform

Elvira2227 · 2021-10-14T10:46:21Z

Some unit tests have been added as an example for the version IFC4X3_ RC4
All tests are missing a IFCHasAnEssentialEntity test, please add
No screenshots were taken. For example, only the one main screenshot is defined for a clothoid, an error is generated for the rest.

NOTE: this pull request was created to replace the old #477, because the old PR was showing changes from other reguest, which is an error

jschlenger

Looks fine to me!

pjanck

General comment: test for IfcSpiral and IfcCurveSegment (or how it's called) in the HasEssentialIfcEntity tests.

...mas/IFC4X3_RC4/bloss-curve_100.0_300_1000_1_Meter/src/bloss-curve_100.0_300_1000_1_Meter.cpp

...s/IFC4X3_RC4/circular-arc_100.0_300_1000_1_Meter/src/circular-arc_100.0_300_1000_1_Meter.cpp

...s/Schemas/IFC4X3_RC4/clothoid_100.0_300_1000_1_Meter/src/clothoid_100.0_300_1000_1_Meter.cpp

pjanck · 2021-11-08T15:59:17Z

UnitTests/Schemas/IFC4X3_RC4/namespace.h

+#pragma once
+#ifndef F7302D7B_948F_445E_8DB9_C722295B8E2E
+#define F7302D7B_948F_445E_8DB9_C722295B8E2E
+
+#if !defined OIP_NAMESPACE_UNITTESTS_SCHEMA_IFC4X3_RC4_BEGIN
+#define OIP_NAMESPACE_UNITTESTS_SCHEMA_IFC4X3_RC4_BEGIN \
+namespace OpenInfraPlatform {\
+namespace UnitTests {\
+namespace Schema {\
+namespace IFC4X3_RC4 {
+#endif
+
+#if !defined OIP_NAMESPACE_UNITTESTS_SCHEMA_IFC4X3_RC4_END
+#define OIP_NAMESPACE_UNITTESTS_SCHEMA_IFC4X3_RC4_END \
+}\
+}\
+}\
+}
+
+#endif
+#endif /* F7302D7B_948F_445E_8DB9_C722295B8E2E */


Are these defines used anywhere?

jschlenger

Generally take a closer look on which IfcEntities are really essential to make the UT work.

...s/IFC4X3_RC4/cosine-curve_100.0_300_1000_1_Meter/src/cosine-curve_100.0_300_1000_1_Meter.cpp

UnitTests/Schemas/IFC4X3_RC4/cubic_100.0_300_1000_1_Meter/src/cubic_100.0_300_1000_1_Meter.cpp

...IFC4X3_RC4/helmert-curve_100.0_300_1000_1_Meter/src/helmert-curve_100.0_300_1000_1_Meter.cpp

...hemas/IFC4X3_RC4/sine-curve_100.0_300_1000_1_Meter/src/sine-curve_100.0_300_1000_1_Meter.cpp

...IFC4X3_RC4/viennese-bend_100.0_300_1000_1_Meter/src/viennese-bend_100.0_300_1000_1_Meter.cpp

Elvira2227 · 2022-01-27T16:43:26Z

In the last commit new unit tests were added for clothoid and line. The tests also contain images.
There are some problems with previos geometries:

Incircular-arc and helmert-curve there are visible geometry on the UI, but some tests (VertexViews and PlaneSurfaceViews) are failed.
In cosine-curve and sine there are no visible geometry in the UI. And also some tests are failed
cubic, viennese-bend produce errors by testing geometry in the UI

And some screen shots:

Elvira2227 · 2022-01-27T16:54:27Z

And there is a question about how does the AllEntitiesAreRead work? or how must it work correctly?
Usually we should count the numbers of entities, but in the last test it counts only the number of the type unsigned __int64 (and what does it mean exactly?). For example, in clothoid there are 80 entities and while launching local debugger the test AllEntitiesAreRead fails (see a screen shot).

jschlenger

As discussed live:

only top view (all the other views can be deleted because there are only 2D lines)
new issue for IfcSine (since we are missing the corresponding GetDirection and GetPoint function)
Files that produce error messages have missing references in the IFC file

…n helmert curve

Elvira2227 · 2022-02-08T16:43:23Z

In the last commit 71f684b screenshots were updated. New screenshots contain only main and top view (Unnecessary Test was deleted).

For bloss, helmeert, sine, cosine we need to add corresponding functions to impement them (See [REQUEST]Implementing corresponding functions for IfcSpline #524 )
Cubic and viennese-bend curves were not impemented and the problem with IFC file was not found. (Like in helmert or in clothoid files)
Clothoid and Lines completed with producing unit tests

jschlenger

The name of circular-arc_100.0_300_1000_1_Meter_top123.png should be changed slightly since we just put that name for a quick test (or maybe the file isn't needed anymore then you should delete it).

Although the unit tests for cosine curve, sine curve, vienesse bend, and cubic curve do not work yet I would suggest to adapt the UTs to compare only the top view.

jschlenger

Looks fine to me. Except for the four UTs that are still missing a couple of functions to work properly all of the UTs are passing?

pjanck

Two small comments.

pjanck · 2022-02-15T14:48:16Z

...s/IFC4X3_RC4/circular-arc_100.0_300_1000_1_Meter/src/circular-arc_100.0_300_1000_1_Meter.cpp

-	buw::storeImage(testPath("circular-arc_100.0_300_1000_1_Meter_right.png").string(), image_right);
-	buw::storeImage(testPath("circular-arc_100.0_300_1000_1_Meter_back.png").string(), image_back);
-	*/
+	//buw::storeImage(testPath("circular-arc_100.0_300_1000_1_Meter_top123.png").string(), image_top);


A ...top123 image is committed as well. Is there a specific reason? Remove otherwise.

pjanck · 2022-02-15T14:51:02Z

UnitTests/Schemas/IFC4X3_RC4/cubic_100.0_300_1000_1_Meter/Data/cubic_100.0_300_1000_1_Meter.ifc

 #34 = IFCRELNESTS('1FNFyHAJeHwuDtwDZHIYIj', $, $, $, #21, (#30));
 #35 = IFCCOMPOSITECURVE((#36), .F.);
-#36 = IFCCURVESEGMENT(.DISCONTINUOUS., #42, IFCPARAMETERVALUE(0.), IFCPARAMETERVALUE(100.), #45);
+#36 = IFCCURVESEGMENT(.DISCONTINUOUS., #42, IFCPARAMETERVALUE(0.), IFCNONNEGATIVELENGTHMEASURE(100.), #45);


Is there a reason that we had to change this?

I thought there was a mistake there, because in other ifc's always come IFCPARAMETERVALU and than IFCNONNEGATIVELENGTHMEASURE. Is it correct?

In this case it doesn't matter, so you can leave it as is or change it: I only have a preference to not change the original file if not necessary.

New unit tests was added

70fb029

Elvira2227 requested review from jschlenger and pjanck October 14, 2021 10:46

Elvira2227 self-assigned this Oct 14, 2021

Elvira2227 added example-files Issue related to failing reading an example file IFC Content related to Industry Foundation Classes (IFC) functionalities labels Oct 14, 2021

jschlenger reviewed Oct 27, 2021

View reviewed changes

pjanck suggested changes Nov 8, 2021

View reviewed changes

jschlenger reviewed Nov 11, 2021

View reviewed changes

Elvira2227 added 4 commits December 1, 2021 21:09

Merge remote-tracking branch 'tumcms/development' into UTIFC4X3_RC4

259e1ae

Merge branch 'development' into UTIFC4X3_RC4

aed79c3

Merge remote-tracking branch 'tumcms/development' into UTIFC4X3_RC4

1ae9e23

Added new UT for clothoid's and lines, images were updated

ea463d4

Elvira2227 requested review from jschlenger and pjanck January 27, 2022 20:20

jschlenger requested changes Jan 28, 2022

View reviewed changes

Updated screenshots and unit tests; Fixed problem with reading .ifc i…

71f684b

…n helmert curve

Elvira2227 mentioned this pull request Feb 8, 2022

[REQUEST]Implementing corresponding functions for IfcSpline #524

Open

6 tasks

Elvira2227 requested a review from jschlenger February 8, 2022 16:43

jschlenger requested changes Feb 9, 2022

View reviewed changes

Updated some UTs; Circular arc screenshots updated and fixed mistake

5adcd71

Elvira2227 requested a review from jschlenger February 9, 2022 14:05

jschlenger reviewed Feb 9, 2022

View reviewed changes

Cubic ifc Datei updated

4089f6d

pjanck suggested changes Feb 15, 2022

View reviewed changes

Elvira2227 added 2 commits February 18, 2022 10:56

Merge remote-tracking branch 'tumcms/development' into UTIFC4X3_RC4

a0e7d1d

Merge remote-tracking branch 'tumcms/development' into UTIFC4X3_RC4

5ab97b8

Merge remote-tracking branch 'tumcms/development' into UTIFC4X3_RC4

165ff08

Elvira2227 mentioned this pull request Jun 13, 2022

IfcSeventhOrderPolynomialSpiral #552

Merged

Elvira2227 mentioned this pull request Aug 9, 2022

[BUG] Missing parameter "ParentCurve" #564

Open

Conversation

Elvira2227 commented Oct 14, 2021

Uh oh!

jschlenger left a comment

Choose a reason for hiding this comment

Uh oh!

pjanck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pjanck Nov 8, 2021

Choose a reason for hiding this comment

Uh oh!

jschlenger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Elvira2227 commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Elvira2227 commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jschlenger left a comment

Choose a reason for hiding this comment

Uh oh!

Elvira2227 commented Feb 8, 2022

Uh oh!

jschlenger left a comment

Choose a reason for hiding this comment

Uh oh!

jschlenger left a comment

Choose a reason for hiding this comment

Uh oh!

pjanck left a comment

Choose a reason for hiding this comment

Uh oh!

pjanck Feb 15, 2022

Choose a reason for hiding this comment

Uh oh!

pjanck Feb 15, 2022

Choose a reason for hiding this comment

Uh oh!

Elvira2227 Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pjanck Feb 20, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Elvira2227 commented Jan 27, 2022 •

edited

Loading

Elvira2227 commented Jan 27, 2022 •

edited

Loading

Elvira2227 Feb 18, 2022 •

edited

Loading