Add optional auto-creation of parent dirs for keystore path in LetsEncrypt helpers#31
Open
SteveOberst wants to merge 2 commits intovalb3r:masterfrom
Open
Add optional auto-creation of parent dirs for keystore path in LetsEncrypt helpers#31SteveOberst wants to merge 2 commits intovalb3r:masterfrom
SteveOberst wants to merge 2 commits intovalb3r:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new boolean property
lets-encrypt-helper.auto-create-keystore-dirthat controls whether the helper will automatically create missing parent directories for the configured keystore path.Changes
TomcatWellKnownLetsEncryptChallengeEndpointConfig
IllegalStateExceptionif the parent directory does not exist and auto-create is disabled.JettyWellKnownLetsEncryptChallengeEndpointConfig
Documentation
Tests
New property
Motivation
Previously, the helper would fail with a vague error if the keystore path’s parent directories didn’t exist.
This change makes setup smoother for most cases, while still giving operators the option to disable auto-creation if they prefer strict configuration management.