Skip to content

fix: new drivers builder/loader image logic#2175

Open
rugggger wants to merge 1 commit into01-27-fix_remove_old_driver-builder_for_cos_logicfrom
02-02-fix_new_drivers_builder_loader_image_logic
Open

fix: new drivers builder/loader image logic#2175
rugggger wants to merge 1 commit into01-27-fix_remove_old_driver-builder_for_cos_logicfrom
02-02-fix_new_drivers_builder_loader_image_logic

Conversation

@rugggger
Copy link
Contributor

@rugggger rugggger commented Feb 2, 2026

TL;DR

Improved driver loading mechanism to support local driver distribution and simplified the process of obtaining the correct driver version.

What changed?

  • Removed the copy_cli() function and related code as it's no longer needed
  • Added a new feature flag weka_get_copy_local_driver_files to control driver file handling
  • Created a new get_target_version() function to determine the correct Weka version from either the cluster image or local files
  • Improved kernel signature detection by parsing it directly from driver zip filenames
  • Refactored driver loading logic to use the cluster image for version information while using the appropriate loader image for the actual pod
  • Added helper functions in the drivers package to select the appropriate builder and loader images based on node OS

Copy link
Contributor Author

rugggger commented Feb 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rugggger rugggger force-pushed the 02-02-fix_new_drivers_builder_loader_image_logic branch from e6a016c to 69a4991 Compare February 2, 2026 16:58
@rugggger rugggger marked this pull request as ready for review February 3, 2026 08:16
@graphite-app
Copy link

graphite-app bot commented Feb 3, 2026

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (02/03/26)

3 reviewers were added to this PR based on Anton Bykov's automation.

@rugggger rugggger force-pushed the 02-02-fix_new_drivers_builder_loader_image_logic branch 2 times, most recently from 070a987 to 0be5364 Compare February 3, 2026 10:50
@rugggger rugggger added the run_ci_on_merge_queue_plan Run upgrade-extended test with generated AI hooks label Feb 10, 2026 — with Graphite App
@kristina-solovyova kristina-solovyova removed the run_ci_on_merge_queue_plan Run upgrade-extended test with generated AI hooks label Feb 10, 2026
@kristina-solovyova kristina-solovyova added the run_ci_on_merge_queue_plan Run upgrade-extended test with generated AI hooks label Feb 10, 2026 — with Graphite App
@rugggger rugggger force-pushed the 01-27-fix_remove_old_driver-builder_for_cos_logic branch from 822901b to c7b67ba Compare February 10, 2026 13:03
@rugggger rugggger requested a review from a team as a code owner February 10, 2026 13:03
@rugggger rugggger force-pushed the 02-02-fix_new_drivers_builder_loader_image_logic branch from 0be5364 to cf5bfb8 Compare February 10, 2026 13:03
@rugggger rugggger force-pushed the 01-27-fix_remove_old_driver-builder_for_cos_logic branch from c7b67ba to 9875b33 Compare February 12, 2026 09:15
@rugggger rugggger force-pushed the 02-02-fix_new_drivers_builder_loader_image_logic branch from cf5bfb8 to 1b63302 Compare February 12, 2026 09:15
@rugggger rugggger force-pushed the 01-27-fix_remove_old_driver-builder_for_cos_logic branch from 9875b33 to b7a22d4 Compare February 12, 2026 09:30
@rugggger rugggger force-pushed the 02-02-fix_new_drivers_builder_loader_image_logic branch from 1b63302 to 18742c2 Compare February 12, 2026 09:30
@rugggger rugggger force-pushed the 02-02-fix_new_drivers_builder_loader_image_logic branch from 18742c2 to 4fd16bf Compare February 12, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_ci_on_merge_queue_plan Run upgrade-extended test with generated AI hooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants