fix: remove legacy dist mode code#2114
Open
rugggger wants to merge 1 commit into01-21-fix_build_locally_and_load_build-id_driversfrom
Open
fix: remove legacy dist mode code#2114rugggger wants to merge 1 commit into01-21-fix_build_locally_and_load_build-id_driversfrom
rugggger wants to merge 1 commit into01-21-fix_build_locally_and_load_build-id_driversfrom
Conversation
This was referenced Jan 25, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
assafgi,
kristina-solovyova and
tigrawap
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (01/25/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
assafgi
approved these changes
Jan 25, 2026
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
99d72e8 to
743d612
Compare
rugggger
force-pushed
the
01-25-fix_remove_legacy_dist_mode_code
branch
from
eecdcde to
769ab18
Compare
This was referenced Feb 2, 2026
rugggger
force-pushed
the
01-25-fix_remove_legacy_dist_mode_code
branch
from
769ab18 to
fa9ab25
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
743d612 to
855aed8
Compare
rugggger
force-pushed
the
01-25-fix_remove_legacy_dist_mode_code
branch
from
fa9ab25 to
b0dc408
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
855aed8 to
a73b66a
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
a73b66a to
7eb10dd
Compare
rugggger
force-pushed
the
01-25-fix_remove_legacy_dist_mode_code
branch
from
b0dc408 to
1a1c6fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed the deprecated "dist" mode and related functionality from the weka-operator runtime script.
What changed?
copy_drivers()function which was only used in the deprecated "dist" modeconfigure_traces()function that disabled tracesHow to test?
Why make this change?
The "dist" mode was deprecated and has been replaced by more specific modes like "drivers-builder". This change cleans up the codebase by removing unused code paths, making the runtime script more maintainable and reducing potential confusion about which modes should be used. The functionality previously provided by "dist" mode is now handled by other more specialized modes.