-
Notifications
You must be signed in to change notification settings - Fork 229
Remove support for Ruby 3.1 and aligned JRuby 9.4 #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The JRuby failures make me think that in practice this PR needs to land on top of #508. |
e290fa9 to
1a16b19
Compare
e5a99e2 to
150583b
Compare
|
|
|
Note that this includes some of the JRuby support fixes from #508. |
|
This could probably use more review than "we finally got CI to pass." |
|
This patch only differs from the prior attempt in that the CHANGELOG was updated. This failure is the same failure as from two runs ago. I do not see it on my machine. I could use help investigating. |
|
I can now intermittently reproduce this failure locally. |
e0748a8 to
68a71fd
Compare
|
This drops Ruby 3.1 support, which means dropping JRuby 9 support, which means using JRuby 10, on which Rubycritic doesn't quite work yet. Is that an acceptable tradeoff? |
I didn't see this PR before; even though Ruby 3.1 is EOL, IMO, it is fine keeping support on it since we want/need to support as many Ruby versions as we can (as long as it is not torture), If it is hard to make their tests pass we can move it to But I would love to know what @etagwerker thinks about it. |
I don't have a particular urgency to kill 3.1 support, but am trying to keep this PR current so we have the option when we decide to drop the support. Also see #482 for additional discussion of when we should be in the habit of doing such things. |
ae4d685 to
7c24551
Compare
5043b3a to
aa2bcff
Compare
- rubycritic.gemspec: update minimum Ruby version to 3.2 - .rubocop.yml: update target Ruby version to 3.2 - CI: drop Ruby 3.1 and jruby 9.4 (Ruby 3.1) - bump mdl dependency to 0.15.0, which requires ruby 3.2 at minimum - bump minitest dependency to 6.0, which requires ruby 3.2 at minimum - minitest 6 unbundles minitest-mock, so include that and call it
Per https://endoflife.date/ruby, Ruby 3.1 is EOL. This PR prepares for when we want to drop support.
Check list: