Skip to content

Conversation

@faisal
Copy link
Contributor

@faisal faisal commented Dec 28, 2025

For consideration, since this has implications beyond fixing a bug:

  1. This updates Rubycritic's FakeFS dependency to the 3.2.0.
  2. Doing so fixes test errors we've seen in supporting Rubycritic on Ruby 4.0
  3. FakeFS 3.2.0 no longer needs irb in the bundle, so remove it.
  4. THIS CHANGE WILL NOT WORK ON RUBY 3.1. If we drop Ruby 3.1 support we should also pull in Remove support for Ruby 3.1 and aligned JRuby 9.4 #514 or something like it.

Check list:

- Move to FakeFS 3.2, which fixes some underlying test issues
- Drop the irb dependency since FakeFS no longer needs it

# Conflicts:
#	CHANGELOG.md
@faisal
Copy link
Contributor Author

faisal commented Dec 28, 2025

This PR will go green once fixes/555 merges in main and so it won't have Ruby 3.1 jobs to fail in the first place.

Alternatively, I could re-PR it to main while fixes/555 continues baking.

@faisal faisal mentioned this pull request Dec 29, 2025
3 tasks
@etagwerker etagwerker merged commit 78ea478 into whitesmith:fixes/555 Dec 29, 2025
30 of 34 checks passed
@faisal faisal deleted the 555_update_fakefs branch December 29, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants