Unpacking breaks for usual parameter vectors

[MSRudolph]

By looping for parameter in parameters, parameter can be a float. The current implementation breaks the function.

[codecov]

Codecov Report

Merging #486 (fbd1f81) into dev (15de61d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #486   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          85       85           
  Lines        6590     6590           
=======================================
  Hits         6223     6223           
  Misses        367      367           

Impacted Files	Coverage Δ
src/python/zquantum/core/circuits/_generators.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15de61d...fbd1f81. Read the comment docs.

[mstechly]

Could you add a test which checks this behaviour?
Also, I think it might not work if the parameters are sympy symbols, could you also check for that?

[AthenaCaesura]

Also, shouldn't mypy take care of this? If parameter isn't an array (at least 1d) then you should get a mypy error.

[MSRudolph]

mypy doesn't notice, because parameters: np.ndarray doesn't have a specified dimensionality. Try this:

from zquantum.core.circuits import Circuit, RX, apply_gate_to_qubits
apply_gate_to_qubits(Circuit(), (0, 1), RX, np.array([1, 2]))