chore(26.04): bump libnode to 127#873
Merged
lczyk merged 12 commits intocanonical:ubuntu-26.04from Feb 19, 2026
Merged
Conversation
3 tasks
Member
|
Blocked by #874 |
Collaborator
|
Collaborator
|
lczyk
requested changes
Feb 5, 2026
Collaborator
lczyk
left a comment
lczyk
left a comment
There was a problem hiding this comment.
a bunch of things to poke at. some slightly weird slicing + inconsistent slicing of the .map files. also two extra bits:
-
a lot of these feel very testable. yes, the tests woudl also install node, but that woudl go a way to showing the package works fine (all the
require's resolve etc) -
if i'm not mistaken the typescript files are not actually runtime deps at all. you sometimes include them in libs and sometimes dont. should we separate them into s separate slice? maybe
libs,typescriptandmaps.. 🤔
on an approving note:
all the *.so libs are correct afaict, libnode127 is ok and nodejs is ok 👍
Test CoverageAverage Total Coverage: 51.67% Arch: aarch64Coverage: 51.67%
|
3 tasks
Collaborator
cjdcordeiro
requested changes
Feb 13, 2026
Collaborator
|
Collaborator
|
installability failing on a bunch of unrelated stuff. adding them here for future 26.04 work:
|
3 tasks
Collaborator
This was referenced Feb 16, 2026
Merged
3 tasks
Collaborator
3 tasks
lczyk
approved these changes
Feb 19, 2026
Collaborator
|
wooho! 🥳 after many many blockers all passing ( except for 'removed slices' which is expected to fail and its ok because this is targeting 'devel' ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This fixes the missing package
libnode115in 26.04Related issues/PRs
Unblocks #783
Forward porting
N/A
Checklist
Additional Context