Skip to content

Comments

feat(26.04): improve systemd slices#878

Open
Meulengracht wants to merge 6 commits intocanonical:ubuntu-26.04from
Meulengracht:bugfix/systemd-26
Open

feat(26.04): improve systemd slices#878
Meulengracht wants to merge 6 commits intocanonical:ubuntu-26.04from
Meulengracht:bugfix/systemd-26

Conversation

@Meulengracht
Copy link
Member

Proposed changes

Improvements to systemd slices, including more segregation of functionality. These were made as a part of making Ubuntu Core 26 work.

Checklist

@Meulengracht Meulengracht changed the title slices: improve systemd slices feat(26.04): improve systemd slices Feb 2, 2026
@lczyk
Copy link
Collaborator

lczyk commented Feb 2, 2026

  • blocked on ci error preparing lxd machine in test #828. working on a fix. for now cancelled the integration tests as they would never succeed and eventually time out, and they were taking up worker allocation. will re-trigger when ci is back to a working state. apologies for the inconvenience!

@lczyk lczyk added the Blocked Waiting for something external label Feb 2, 2026
@ROCKsBot ROCKsBot requested a review from a team February 3, 2026 01:41
@lczyk
Copy link
Collaborator

lczyk commented Feb 5, 2026

@lczyk lczyk removed the Blocked Waiting for something external label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage

Average Total Coverage: 100.00%


Arch: aarch64

Coverage: 100.00%

systemd: ☂️ 100.00% (0 missing)

Arch: x86_64

Coverage: 100.00%

systemd: ☂️ 100.00% (0 missing)

Copy link
Member

@alesancor1 alesancor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big PR but looks pretty good already, thanks for the effort! Some comments below:

Comment on lines 7 to 8
# now a placeholder, just redirects to core
bins:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well since we are moving to a new base, regressions are acceptable to some extent. We can consider deprecating bins in favour of standard here - lmk what you think @canonical/rocks

Comment on lines 17 to 26
- libssl3t64_libs
- libsystemd-shared_libs
- libsystemd0_libs
- mount_bins
- systemd_catalog
- systemd_config
- systemd_detect-virt
- systemd_kernel-parameters
- systemd_network
- systemd_pcrlock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind leaving all these outside core?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since those are not strictly neccessary for core systemd functionality, you could argue network would be nice in any case but still

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future work - not to be addressed in this PR:

We should probably test the slices individually via variants + sh scripts rather than a big test for _bins or _standard.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed ☝️

@ROCKsBot ROCKsBot requested a review from a team February 8, 2026 01:41
@Meulengracht Meulengracht mentioned this pull request Feb 16, 2026
3 tasks
@lczyk lczyk added the Priority Look at me first label Feb 17, 2026
@lczyk
Copy link
Collaborator

lczyk commented Feb 17, 2026

adding 'priority' since blocking:

@lczyk
Copy link
Collaborator

lczyk commented Feb 19, 2026

fyi, i've extracted minimal changes required for the CI of libnode to pass in this PR: #916. it should merge with the changes here cleanly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority Look at me first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants