Removal of code duplication for charge computation in trr_test_suite

[pcorcam]

Removes code duplication in the trr_test_suite regarding the charge computation. More specifically:

• ChargeContainer and ChargeComp are removed from trr_test_suite/tools_components.py;
• The standard ChargesComponent (makers/components/charges_components.py) is now the component in the LinearityTestTool (trr_test_suite/tools_components.py);
• The script trr_test_suite/linearity.py has been adapted accordingly - pedestals are precomputed with the standard PedestalNectarCAMCalibrationTool and its output is fed to the ChargesComponent in the LinearityTestTool.

A crosscheck was performed to test the compatibility of both charge-extraction methods. The parameters:

• run_number = 6954
• max_events = 500
• window_width = 16
• window_shift = 6
• For standard ChargesComponent:
  • method=LocalPeakWindowSum
  • pedestal is computed with PedestalNectarCAMCalibrationTool with parameters:
    • max_events = 12000
    • events_per_slice = 5000
    • method = FullWaveFormSum
    • filter_method = None

We find good agreement between the two charge-extraction methods (see figures below); the relative difference is on average $\mu = 0.0045$% with a standard deviation $\sigma = 0.5335$%.

Note that there is still quite some code duplication regarding charge computation in trr_test_suite/tools_components.py, notably in ToMComp. This will be tackled in a future PR.

[codecov]

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.00%. Comparing base (e8a4985) to head (d2f0917).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/nectarchain/trr_test_suite/tools_components.py	12.50%	7 Missing ⚠️
src/nectarchain/trr_test_suite/linearity.py	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   51.71%   52.00%   +0.29%     
==========================================
  Files          80       80              
  Lines        6774     6713      -61     
==========================================
- Hits         3503     3491      -12     
+ Misses       3271     3222      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jlenain]

Hi @pcorcam ,

Many thanks for this ! There was a conflict with the freshly merged PR #243 . I rebased this PR against main.

[jlenain]

Thanks a lot also for the comparison before/after, @pcorcam, I think this is really compelling!