Add special sorting for special characters in globs #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleywillard
force-pushed
the
aw/fix-sorting-bug-special-characters
branch
from
61ddec8 to
e7e17b7
Compare
tstannard
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
/frontend/packages/my-thing/src/pages/blahis owned by Foo via a.codeownerfile/frontend/packages/my-thing/src/pages/blah/(bar)is owned by Bar via a.codeownerfileExpected Behavior
The most specific (nested)
.codeownerfile should take precedence, so/frontend/packages/my-thing/src/pages/blah/(bar)/Sidebar.test.tsxshould be owned by Bar.Actual Behavior
/frontend/packages/my-thing/src/pages/blah/(bar)/Sidebar.test.tsxshows that it is owned by Foo. This is because/frontend/packages/my-thing/src/pages/blah/(bar)is written above/frontend/packages/my-thing/src/pages/blahin theCODEOWNERSfile.This change
This change updates the file sorting such that if two globs match up until a
**, then the one without the**at that location will be prioritized. This ensures that the more specific folder will come last, which means that the file will show the proper owner.Performance seems comparable