EXT_feature_metadata: featureTables/featureTextures → propertyTables/propertyTextures#17
Conversation
…s/propertyTextures
|
I added From there the extension should be able to quickly answer
|
|
Hm, yeah Though personally I like the sound of Thinking through it, if you zoom out that's what we're describing. we have a mesh, and whether at the vertices, or texels along each face there's some sort of properties associated with the geometry. |
|
As a sanity check (since most of my experience with the word "feature" is in geospatial and product development contexts) here is a dictionary definition of the term:
I think that's appropriate, although I do also like If we are using the word "mesh" then I don't think the term "batch" or "batching" is needed; a mesh does not have to represent a batch, the artist might be thinking of their product asset (e.g. a lamp) as a single mesh and they want to display contextual information when parts of the product are hovered or interacted with. |
|
My main problem with the name The definition for "features" fits really well. I don't think we have to shy away from the word feature too much. |
|
I'm happy with |
|
@donmccurdy yes |
|
@ptrgags sounds good, let me know if there are any other issues with the PR then! |
ptrgags
left a comment
There was a problem hiding this comment.
@donmccurdy noticed a couple things to be updated after the rename
extensions/2.0/Vendor/EXT_feature_metadata/schema/propertyTexture.schema.json
Outdated
Show resolved
Hide resolved
|
@donmccurdy looks good now, thanks! |
Renames:
featureTable→propertyTablefeatureTexture→propertyTextureI've also attempted to use the term "properties" instead of "metadata" in a few cases, but may have a few more to clean up in the language/clarity pass.
We've discussed perhaps renaming the extension from
EXT_feature_metadata. Also see #4. The nearest extension in the glTF specification isEXT_mesh_gpu_instancing, for reference. Ideas, in no particular order:EXT_mesh_batchingEXT_mesh_feature_batchingEXT_mesh_propertiesEXT_feature_propertiesEXT_mesh_featuresIf we do want to rename I'll do that update in a separate PR, but it does relate a bit to the wording used in this change. /cc @ptrgags @lilleyse