Skip to content

fix: add DefaultCliContainer#2092

Open
rugggger wants to merge 1 commit intomainfrom
01-20-fix_add_defaultclicontainer
Open

fix: add DefaultCliContainer#2092
rugggger wants to merge 1 commit intomainfrom
01-20-fix_add_defaultclicontainer

Conversation

@rugggger
Copy link
Contributor

@rugggger rugggger commented Jan 20, 2026 •
edited
Loading

TL;DR

Added functionality to copy the Weka CLI from a shared volume to driver loader pods.

What changed?

  • Added a copy_cli() function in weka_runtime.py that copies the Weka CLI from a shared volume to /usr/bin/weka if available
  • Created a new CopyWekaCliToMainContainer() function that adds an init container to copy the Weka CLI to a shared volume
  • Added a defaultCliContainer configuration parameter to specify which container image to use for the CLI
  • Modified the driver loader pod creation to include the CLI copying functionality
  • Added environment variable configuration for the default CLI container

https://wekaio.atlassian.net/browse/OP-226

@rugggger Graphite App
Copy link
Contributor Author

rugggger commented Jan 20, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rugggger rugggger marked this pull request as ready for review January 20, 2026 13:26
@graphite-app
Copy link

graphite-app bot commented Jan 20, 2026

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (01/20/26)

3 reviewers were added to this PR based on Anton Bykov's automation.

@rugggger rugggger mentioned this pull request Jan 21, 2026
Open
assafgi
assafgi reviewed Jan 21, 2026
View reviewed changes
charts/weka-operator/resources/weka_runtime.py Outdated


# Copy weka CLI from shared volume if available (for custom builder images)
copy_cli()
Copy link
Contributor

@assafgi assafgi Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be called only for mode == builder

Copy link
Contributor Author

@rugggger rugggger Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed for drivers-loader as well
it won't copy the cli unless it already exists in the shared-weka-cli folder - if not there it is just skipped (it is copied only when init-container puts it there - for builder/loader)

I can add the condition if you want to make it more explicit

Copy link
Contributor

@assafgi assafgi Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we already have such in this file

kristina-solovyova
kristina-solovyova reviewed Jan 21, 2026
View reviewed changes
@rugggger rugggger mentioned this pull request Jan 21, 2026
Open
@rugggger rugggger force-pushed the 01-20-fix_add_defaultclicontainer branch from aeb02fa to 6a7d283 Compare January 21, 2026 13:32
This was referenced Jan 21, 2026
Open
Closed
assafgi
assafgi reviewed Jan 22, 2026
View reviewed changes
charts/weka-operator/resources/weka_runtime.py

# Copy weka CLI from shared volume if available (for custom builder images)

if MODE in ["drivers-loader", "drivers-builder"]:
Copy link
Contributor

@assafgi assafgi Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be moved to main function

Copy link
Contributor Author

@rugggger rugggger Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved it later up the stack PR 2102

@rugggger rugggger requested a review from assafgi January 22, 2026 07:20
@rugggger rugggger force-pushed the 01-20-fix_add_defaultclicontainer branch from 6a7d283 to 6db9d56 Compare January 22, 2026 07:45
This was referenced Jan 25, 2026
Open
Open
@assafgi assafgi requested a review from a team as a code owner January 28, 2026 18:09
This was referenced Feb 2, 2026
Open
Open
@rugggger rugggger force-pushed the 01-20-fix_add_defaultclicontainer branch 2 times, most recently from 5970514 to 54c309f Compare February 12, 2026 09:15
@rugggger rugggger force-pushed the 01-20-fix_add_defaultclicontainer branch from 54c309f to 55f02bb Compare February 12, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assafgi assafgi assafgi approved these changes

@kristina-solovyova kristina-solovyova kristina-solovyova approved these changes

@tigrawap tigrawap Awaiting requested review from tigrawap

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rugggger @assafgi @kristina-solovyova