fix: build locally and load build-id drivers#2102
fix: build locally and load build-id drivers#2102rugggger wants to merge 2 commits into01-21-fix_use_builder_images_in_local_builder_podsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
assafgi,
kristina-solovyova and
tigrawap
and removed request for
kristina-solovyova
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (01/22/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
| ) | ||
|
|
||
| # weka_dist_service - any distribution service weka owns (not client maintained) | ||
| def weka_dist_service(): |
There was a problem hiding this comment.
because some clients have their own distribution system (they build and download from a VM) and we don't want to break their system by enforcing a build id (which they didnt put and we cant control)
this condition limits the logic only to our owned builds
There was a problem hiding this comment.
even if they have other dist, you still need the build id for calculation
also you use this condition only for ubuntu24
There was a problem hiding this comment.
I use this condition only for ubuntu24 - and only if we build it
There was a problem hiding this comment.
I don't need the build id if it's loading a driver from their dist - I count on it to be the right build (their responsibility)
rugggger
force-pushed
the
01-21-fix_use_builder_images_in_local_builder_pods
branch
from
a8d585b to
4679e84
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
50d9dd1 to
99d72e8
Compare
rugggger
added
the
run_ci_on_merge_queue_plan
Graphite App
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
99d72e8 to
743d612
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
743d612 to
855aed8
Compare
rugggger
force-pushed
the
01-21-fix_use_builder_images_in_local_builder_pods
branch
2 times, most recently
from
7182e5d to
b26fca6
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
855aed8 to
a73b66a
Compare
rugggger
force-pushed
the
01-21-fix_use_builder_images_in_local_builder_pods
branch
from
b26fca6 to
fe20961
Compare
rugggger
force-pushed
the
01-21-fix_build_locally_and_load_build-id_drivers
branch
from
a73b66a to
7eb10dd
Compare
2 participants
No description provided.